-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup] Changing Selectors For Payments And Quotes #2106
[Cleanup] Changing Selectors For Payments And Quotes #2106
Conversation
@Civolilah should i be able to typeahead with these? Or are they only pure selects? |
@turbo124 These are pure selects, because we've already made searchable selects with the same design for selectors where we thought it would be great to have a search option. If you want to make all of them with a search option, it's not a problem; it's literally just passing one prop. Let me know your thoughts. |
@Civolilah search option is best of both worlds, please change to that. |
@turbo124 Okay, so right now those fields are also made searchable. Please let me know your thoughts. |
@turbo124 Okay, sure, so the clear button is only available if there is a selected value. Screenshot: Let me know your thoughts. |
@beganovich @turbo124 The PR includes changing current selectors with new ones for Payments and Quotes. Screenshot:
Let me know your thoughts.